LMMS / LMMS/lmms

[stable-1.2] Do not hardcode a prefix in CMakeLists

Open
#6,792 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

`stable-1.2` hardcodes Homebrew prefix in CMakeLists: https://github.com/LMMS/lmms/blob/afaceadce6ebfa2ab1dcc0b1b37bba5523a0c532/CMakeLists.txt#L74-L76
This has been fixed by @tresf in `master` in https://github.com/LMMS/lmms/commit/131b2738949212be9676c97a9733a8e245b9119e

Could we backport that? Firstly, we support `lmms` in Macports. Secondly, end-user should be free to choose alternative prefix, unrelated to package managers.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the referenced CMakeLists.txt lines on stable-1.2 and compare them with commit 131b2738949212be9676c97a9733a8e245b9119e on master. Backport the existing fix so the Homebrew prefix is not hardcoded, then verify that alternative prefixes used by MacPorts and end users remain supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.