LMMS / LMMS/lmms

Note move and note deletion actions are undone together if originally performed during piano roll playback

Open
#6,668 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

### Bug Summary
If a note is deleted after a different note is moved in the piano roll during playback, attempting an undo will treat both discrete actions as a single action, undoing them both. Similarly, subsequently attempting a redo will restore both actions together. Half of the time it seems to work.
#### Steps to reproduce
1. Place notes on the piano roll.
2. Begin playback on the piano roll.
3. Move a note and then delete another note.
4. Attempt an undo with Ctrl+Z
#### Expected behavior
Only the note deletion is undone.
#### Actual behavior
Both the note deletion and the earlier note move are undone together.
#### Screenshot
https://user-images.githubusercontent.com/6764216/224560441-41873393-96b2-413d-a65c-711d5718e557.mp4
#### Affected LMMS versions
1.3.0-alpha.1.277+g2baa23ee1 (win32/x86_64, Qt 5.9.8, GCC 7.3-win32 20180312)
Windows 10 64-bit

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the piano roll using the listed playback, move, delete, undo, and redo steps. Trace the piano roll's undo/redo handling while playback is active; done means the deletion and earlier note move are treated as separate actions in both directions.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.