Crash when stopping MIDI recording while sustain pedal is pressed
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
### Bug Summary
LMMS crashes after stopping a piano roll MIDI recording while sustain pedal is pressed.
#### Steps to reproduce
1. Connect and configure a MIDI keyboard with a sustain pedal
2. Open the piano roll editor
3. Start a new MIDI recording
4. Press any note on your keyboard while holding the sustain pedal
5. Press the stop recording button while the sustain pedal is still pressed
#### Expected behavior
LMMS stops the recording and releases all keys that are still pressed.
#### Actual behavior
LMMS crashes instantly.
After reopening the project and pressing **recover** the recording is **lost completely**!
#### Affected LMMS versions
Version 1.2.2 (Linux/x86_64, Qt 5.15.3, GCC 11.2.0) installed using Flatpak
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the crash with a MIDI keyboard and sustain pedal by stopping piano roll recording while the pedal remains pressed. Trace the recording-stop handling and verify that stopping releases held keys without crashing and that the recording is retained after recovery.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100