LMMS / LMMS/lmms

Unable to rename sidebar-imported sample-track content

Open
#6,422 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

### Bug Summary
There is no method that can rename an imported sample in a sample-track. The sample gets the diskname, and that cant be changed. The actual sample-track-button is how ever named _Sample-track_, and not the disk-name.
The name on the button _can_ be changed

#### Steps to reproduce
Browse to a sample from sidebar, and choose _open-in-new-sample-track_
You get something like
![image](https://user-images.githubusercontent.com/6662066/171906142-17d0e760-f61e-4387-ab5f-d48aef9a6231.png)

#### Expected behavior
Right-clicking the sound-clip should offer the same naming-options as we have for right-clicking a midi-clip
Context of Sample-track:
![image](https://user-images.githubusercontent.com/6662066/171906701-0d52146f-d540-4fec-953e-58aa2553d9fe.png)

Context of midi-track:
![image](https://user-images.githubusercontent.com/6662066/171906972-7a9b18a5-f5c8-4f65-8089-ace1027255ea.png)

#### Actual behavior
No options

#### Affected LMMS versions
At least 1.3

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the sidebar's open-in-new-sample-track path and inspect how the sample-track button and sound-clip context menus are built. Compare those options with the midi-clip context menu shown in the issue. Done means a sidebar-imported sample offers the same naming options and its displayed sample name can be changed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.