LMMS / LMMS/lmms

Allpass Delay Line, Noninterpolating causes Clicking

Open
#6,394 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug upstream
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

### Bug Summary
Allpass delay line, noninterpolating causes clicking effect when its Delay Time knob is toggled while the note is playing.
Given that it has no other use, I would characterize this more as a useful(?) quirk and less as a bug.

#### Steps to reproduce
1) Play any instrument, or a sample track, with sounds that don't themselves have clicking and have long note lengths.
2) Add 'Allpass delay line, noninterpolating' effect in the effects chain or FX Mixer.
3) Toggle the Delay Time knob to get a continuous clicking effect, or change it to a different value to get a single click. Alternately, automate it analogously.

#### Expected behavior
Nothing.
(Who knows? What is the Expected behavior of Allpass delay line? Everything I've read about it says that it is "Nothing at all.")
#### Actual behavior
Clicking. One click per change in value of Delay Time
#### Screenshot

https://user-images.githubusercontent.com/103920743/166696575-779de6b7-8489-4b35-9d70-495c65bc9dfc.mp4

#### Affected LMMS versions
1.2.2, 1.3.0 (tried only on those)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the clicking with the “Allpass delay line, noninterpolating” effect by changing or automating its Delay Time while a long note plays. Locate the effect implementation and any related tests, then establish the intended behavior before deciding what would constitute a fix.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.