Undo track solo selection broken
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
### Bug Summary
The undo action seems to exhibit odd behavior when trying to undo the toggling of the "solo" or "mute" buttons in the Song Editor.
#### Steps to reproduce
1. Open blank project
2. Press the "solo" button on one track
3. Repeat step 2
4. Repeatedly press Ctrl+Z mutliple times, observing the behavior each press.
Other odd behavior can be observed by toggling the "mute" button instead of the "solo" button. Try skipping step 3 to observe other odd behavior. Or run step 4 before and after step 3 for more unusual behavior.
#### Expected behavior
Ctrl+Z undoes the toggling of the "mute" button or the "solo" button. In the case of the solo button, it should properly unmute or mute the other tracks.
#### Actual behavior
Some presses seem to do nothing, others unmute tracks one by one when they should be unmuted together, etc. The behavior seems to be diffferent depending on the steps taken in the **Steps to reproduce** section above.
#### Screen Recording
I pressed Ctrl + Z over 8 times in this recording. The first 4 seemed to do nothing.
https://user-images.githubusercontent.com/55554300/147799075-2b5dd1a2-6256-4be2-96e4-5b20e43131ce.mp4
#### Affected LMMS versions
1.3.0-alpha 13e17496dcfe46723b67a322159d8486cd92b650
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the Song Editor using the listed solo and mute toggle sequences, then inspect the undo handling for those actions. Done means Ctrl+Z consistently reverses each toggle and restores all affected tracks together, including the solo behavior described under Expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100