BBEditor and PianoRoll continue to play pattern even after closed
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
Bug Summary
Piano Roll and BB Editor continue to play current pattern even after closed. There is no visual indication where the pattern is playing from.
Steps to reproduce
- Create an instrument or BB pattern in the Song Editor.
- Double click to open in Piano Roll or BB Editor
- Add some notes/beats
- Click play in the Piano Roll or BB Editor
- Close Piano Roll or BB Editor
Expected behavior
Pattern that was playing in BB Editor or Piano Roll stops playing when window is closed.
Actual behavior
Pattern continues playing.
Affected LMMS versions
1.3.0-alpha 13e17496dcfe46723b67a322159d8486cd92b650
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by opening a pattern in Piano Roll or BB Editor, starting playback, and closing the editor. Trace how each editor handles closing while playback is active; done means the pattern stops immediately when either window closes and no longer plays invisibly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100