LMMS / LMMS/lmms

Ghost Notes - Grey Note Boxes Come Up A Little Short

Open
#6,247 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

When you add Ghost Notes into the Piano Roll if zoom in to the right side of any grey note box you will see that the notes don't go all the way to the vertical beat / bar lines.
I think the reason for this is that active notes have a bright green grip on the right side of each note to adjust the note length and the Ghost Note graphics do not account for space those grips fill.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Piano Roll by reproducing the issue with Ghost Notes and zooming near the right side of a grey note box. Inspect the note rendering and compare its end with the vertical beat or bar lines and the space occupied by active-note grips; done means Ghost Notes reach the expected lines without overlap.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.