LMMS / LMMS/lmms

Add a simple label for "root" note and selected key/note range

Open
#6,224 10 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

### Enhancement Summary

#5868 added also a feature to select a key/note range by dragging an arrow from the left and/or the right side of the piano inside the instrument window.

The idea of this enhancement is to add a simple informational label for displaying the "root" note and the selected key/note range. Somehow similar as seen here in the piano roll limiter of FL Studio:

![image](https://user-images.githubusercontent.com/93736385/142763581-84aae045-964b-4f7c-aa2b-ae71f0508716.png)

Taken from here: https://www.image-line.com/fl-studio-learning/fl-studio-online-manual/html/pianoroll_limit.htm

#### Justification

The key/note range is not really visible in the first place and can only be discovered by scrolling to the begin or the end of the piano view which many users may not do without already knowing about the feature. At least this is the state of the master branch some weeks ago.

![image](https://user-images.githubusercontent.com/93736385/142763912-f07f7acb-bb2e-4616-ac82-3f2ab999e561.png)

The discussion in #6210 also showed that this feature may not be as obvious as it should be, because this already implemented feature would e.g. allow the assignment of different notes on channel 10 to use a drum pad. Of course this would not be a really convenient way to set up such a midi channel and key/note assignment - for this a different UI solution may be needed - but it would give an indirect hint to users that a possibility to modify this key/note range is at least likely.

And the additional "root" note display may allow a better visual indication if it was set to a black or white key which is sometimes difficult to see just by the rectangle marker as seen here:

![image](https://user-images.githubusercontent.com/93736385/142764160-d2521576-05ed-4081-967f-0f603a70d2c9.png)

#### Mockup

![image](https://user-images.githubusercontent.com/93736385/142763700-6dda06e8-d0c0-498e-b419-6b1ca0347005.png)

A slight increase in height of the instrument window may be needed though.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the key/note range selection feature from issue #5868 and the discussion in #6210, then inspect the piano UI in the instrument window. Compare the current display with the supplied mockup. Done means the root note and selected key/note range are visibly labeled without requiring users to scroll to either edge.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.