EQ bands bug: bands automatically getting enabled with certain behaviour
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
### Bug Summary
Adding the Equalizer (the native GUI one), enabling one band, then repeatedly hitting Ctrl-Z enables band after band.
#### Steps to reproduce
1. Add equalizer (LMMS) effect to instrument
2. Enable any band by clicking on it
3. Hit Ctrl-Z
#### Expected behavior
Band gets disabled / Ctrl-Z undoes last change
#### Actual behavior
Other bands get enabled
#### Screenshot
https://user-images.githubusercontent.com/76674645/126066039-6b871d62-24ed-4c9b-8022-eff1a31a6485.mp4 (video)
(I had enabled band 4, then hit Ctrl-Z twice)
#### Affected LMMS versions
1.2.0, 1.3 alpha, and presumably everything in between.
(Extra note: faced a bug where clicking one band would enable all bands. Is presumably related, but could not reproduce.)
Contributor guide
No contributing guide indexed for this repository
Research direction
No source file, test, or entry point is identified in the issue. Reproduce the problem in LMMS with the native Equalizer effect, then trace the equalizer band enable action and Ctrl-Z handling. Done means undo disables the last-enabled band instead of enabling other bands.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc, desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100