Garbled track names after importing Shift-JIS encoded MIDI files
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
Steps to reproduce
There are several test files on this random fansite. For example: db-op.mid, jp-country.mid, kor-ed2.mid, slayer-ed.mid, etc.
Expected behavior
I would expect either some heuristics to detect these Shift-JIS encoded files and automagically convert their track names to Unicode, or a combobox at the MIDI import dialog to select this encoding manually.
Actual behavior
Shift-JIS encoded MIDI track names interpreted as Unicode causing garbled track names.
Screenshot
Affected LMMS versions
AppImage, Version 1.2.2 (Linux/x86_64, Qt 5.9.7, GCC 5.4.0 20160609)
Git, fadf8c611ef37cf51fa0dd5c0d188a314c51004b
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the listed MIDI files and trace the MIDI import handling in LMMS. Determine how track-name encoding is interpreted; done means Shift-JIS track names display correctly, either through detection or an encoding choice in the MIDI import dialog.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100