LMMS / LMMS/lmms

Sample clips lose start/end trim when file is changed

Open
#5,861 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

### Bug Summary

Sample clips do not preserve start/end trim when a sample is loaded into them.

#### Steps to reproduce

- Add a sample clip and load a sample
- Trim slightly from left
- Double click the clip and load another sample (for example, the original sample but slightly edited or at a different file location)

#### Expected behavior

Trim is preserved, or an option to preserve it is presented.

#### Actual behavior

Start and end offset are set to zero, with clip start position remaining unchanged.

#### Affected LMMS versions

1.3 alpha 1, presumably all previous versions.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce this in LMMS by loading a sample into a sample clip, trimming it, and then loading another file. Trace the sample clip file-loading path and determine where the start and end offsets are reset. Done means the trim is preserved, or the user is given an explicit option to preserve it, with the reported reproduction no longer resetting both offsets to zero.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.