LMMS / LMMS/lmms

Remove bar doesn't preserve clip offsets

Open
#5,769 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Found while testing 5699, but turns out this happens in 1.2.2 and master builds as well.

#### Steps to reproduce

- Create clips with different start positions in the song editor
- Press "remove bar" (or shift+ delete) until at least one clip is less than a bar away from the start of the song
- Continue pressing "remove bar"

#### Expected behavior

- "Remove bar" should only move clips if all clips can be moved left by a bar

#### Actual behavior

- Different clips may move different distances

#### Screenshot

Here "remove bar" has been pressed repeatedly:

![image](https://user-images.githubusercontent.com/8918426/98417534-66a6a780-2081-11eb-8ff5-0a18bd1c5836.png)

#### Affected LMMS versions

1.2, master

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in the song editor by reproducing the issue with clips at different start positions, then repeatedly use “remove bar” or Shift+Delete as described. Done means the command moves clips left by a bar only when every clip can move that far, preventing different clips from shifting by different distances.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.