LMMS / LMMS/lmms

Long label causes knobs to misalign

Open
#5,518 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

In the Hungarian translation for example, the Gain knob is misaligned due to the longer word:
![erosites](https://user-images.githubusercontent.com/65627470/83018950-72983300-a026-11ea-9ef8-580295dcbf1e.png)
Also the BE and KI labels are a bit off, because the text is probably left-aligned.
A similar thing is going on with many other effects too.

The root problem is that knob widgets start to go right if the label is wider than the knob itself. This is because their position is specified by the upper left corner.

I have already found a way to sorta fix it and will probably make a PR after the reorganization.
Altough the fix itself is no more than a line, it will generate some additional work because in many plugins the knobs are positioned so that they compensate for this bug. I believe that was just a quick and dirty workaround which works for the original English labels only. So when this issue is fixed, all of those will have to be corrected, and also if a label can't be translated to a short enough word in some language, we need to redesign that gui as well, making additional space.

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue names no files, tests, or entry points. Start by locating the knob widget positioning and the affected effect-plugin layouts, then check the Hungarian labels and other translated labels for alignment. Done means labels and knobs remain aligned across translations, with any compensating plugin positions corrected and layouts given more space where needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
design, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.