LMMS / LMMS/lmms

noteEnd() triggered without a corresponding activate()!

Open
#5,373 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug master branch
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

... is a warning that I often see when I play notes quickly by dragging in the piano roll/view.

https://github.com/LMMS/lmms/blob/63d11f763c6f9712e4ee527b28b04bedccdd21fd/src/gui/widgets/FadeButton.cpp#L82

The visible consequence is that the instrument track fade button remains partially lit, like when a note is sustained.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/gui/widgets/FadeButton.cpp around line 82 and reproduce the warning by dragging quickly in the piano roll/view. Trace the note activation and deactivation handling; done means rapid note playback no longer emits the warning and the instrument track fade button does not remain partially lit.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.