None of the data for song-editor, and piano-roll is saved
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
#### Bug Summary
A previously Saved project have apparently 'lost' all data for both song-editor, and piano-roll. It is only logical to assume, that the data never was written to the file, in the save-event. It is not logical to assume, that data can disappear from a correctly saved file. The fail must be in the procedures, that collect all data from the opened project, and writes this data into the save-file. In this case as XML-data in MMP. It is also obvious that data for song-editor must have existed, because the connections between Mixer and each of the missing instruments (16 channels) are present in the current file. Automation editor data was saved.
#### Steps to reproduce
None
#### Expected behavior
All data from open projects should be saved in the file
#### Actual behavior
The project was saved with 16 instruments, and ~2 minutes of notes. After reopening, only the 16 named instrument-busses, in Mixer are preserved/ reloadable. All data for both song-editor, and piano-roll was not saved.
#### Screenshot
No
#### LMMS version used
Off. 1.2.1 on win10
#### Logs
No log. Zip-file, with both mmp-project and a previous autosaved .bak file, included as attachment.
#### Comment
This is only meant as a reminder for later. The bug has the same nature as the #5073 'disappearing-blocks' issue. It is not reproduceable, and has an unknown reason. It may never appear again, but if it does, this is a note and a project-file at first appearance.
[School_Pants.mmp.zip](https://github.com/LMMS/lmms/files/3968213/School_Pants.mmp.zip)
Discord conversation reference: NerdyBumgyu Dec 16 2019 at 7:09 AM
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the attached School_Pants.mmp.zip, comparing the saved .mmp file with the autosaved .bak file and tracing how song-editor and piano-roll data are collected and restored. Reproduce the loss if possible, then verify that both editors' data survives saving and reopening, with the related #5073 issue as context.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100