Paying more attention to PRs
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
# Motivation
Some practical examples:
* @gi0e5b06 forked LMMS, one critique was he expects PRs to be answered immediatelly (and I agree here, I'd say ideally, no "PR" should ever be open and waiting for review)
* One of my PRs (instr-sub-plugins) didn't get attention for two months, many others are still not reviewed.
# Why PRs need more attention
* Coders forget what they did and has more difficulties to answer a review if it's months ago
* Coder says: "I've waited long enough, no comments, so I'll merge". Can make sense, but every bug you merge into master will
affect others (look at our unstable master branch)
# What are the reasons for PRs not reviewed?
At least:
* I often don't know when a PR is ready for review. Should this be marked in the title? Like "[ready] Some title".
* Style review sucks, it should be done by CI. We could use the clang stuff (#4690, #6323) or/and some shell scripts.
* Maybe this is also a current problem of people focussing on 1.2 issues, ignoring master PRs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the proposed causes and the referenced issues #4690 and #6323, including the suggested clang checks and shell scripts. The issue does not define a specific implementation, files, tests, or measurable completion criteria, so the desired workflow would need to be decided before work can begin.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, shell
- Domain
- ci-cd, developer-experience
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100