LMMS / LMMS/lmms

PixmapButton - Undo/Redo

Open
#4,898 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Undo/redo of PixmapButton shows erratic behavior. A single press of a PixmapButton seem to indicate that undo/redo isn't implemented for this class but consecutive presses will register but it's glitchy.

Example one:
Press mute button on a track and then press or use the edit menu function. The action isn't reverted.

Example two:
Press mute button on a track twice followed by two 'undo' actions. The second undo will change the state of the button.

Example three:
With two unmuted tracks in the song editor do the following.
Press the mute button on the first track four times.
Press the mute button on the second track four times.
Press once. Nothing happens.
Press three times. The second track will change state to muted.
Press once. Nothing happens.
Press three times. The first track will change state to muted.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the three examples in the LMMS song editor, using the PixmapButton mute control, Ctrl+z, and the Edit menu. Trace the PixmapButton action into the undo/redo handling; done means each described sequence reverses the expected mute changes in the correct order.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.