LMMS / LMMS/lmms

Preserve plugin state when VST fails to load

Open
#4,850 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Plugins that fail to load should keep their state so users can resolve the loading issue without losing their settings. Quoting DomClark from issue #4843:

> [When a plugin fails to load,] plugin state will [...] be lost; it is deserialised into and serialised from the VST plugin itself, so if the plugin is missing, the state will go too. Perhaps we should keep the whole `QDomElement` if plugin loading fails, and in that case use it to save again. This probably deserves a separate issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Trace the VST loading path and the plugin state serialization/deserialization path, then determine where the QDomElement can be retained when loading fails. Done means a failed VST load preserves its existing state and saves it again without the plugin.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.