LMMS / LMMS/lmms

CPU overload when loading a project with specific VST's

Open
#4,788 10 comments 0 reactions 0 assignees View on GitHub
needs clarification performance
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Hello,

I'm having a CPU overload on remoteVstPlugin.exe when I try to load a project containing specific VST's.

**Steps to reproduce :**
_I asked some people to reproduce it but it seems hard to reproduce, maybe it's not that noticeable on recent computers._
- Open `LMMS 1.2.0-RC7`
- Load [DragonFly Reverb](https://github.com/michaelwillis/dragonfly-reverb) in the master
- Save the project
- Close LMMS
- Open `LMMS 1.2.0-RC7`
- Load the previously saved project
- Look at the CPU usage of the corresponding RemoteVstPlugin.exe

![image](https://user-images.githubusercontent.com/12613367/51495739-a671a180-1dbd-11e9-833d-162b11fbcac3.png)

In my case, it's using 12% of my CPU...
It should use 0% when no note is playing.
When I play a note (with 3xosc) it jumps to 16%, which make LMMS almost unusable when I work on big projects with many more VST (Mequalizer, and all the free MELA plugin suite have the same behavior, and probably lots of other VST I use).

**More infos**
In LMMS 1.1.3 there was no problem, so I try bisecting is suggested by @DomClark
~~Here is what I found : [a2cb7e9](https://github.com/LMMS/lmms/commit/a2cb7e96ea057de604003ecdc70745a80e4b40e0), which fixes a GUI glitch introduced the bug. (The commit just before doesn't have the bug)~~

**My config**
Windows 7 - 64bits

Hope these info will help come up with a solution. I understand that it may be related to the fact my computer is old (4 years old) but maybe there is still an explaination, because it was not there before. Or maybe a workaround to fix this ?

If you need more infos, or want me to try to compile some of your ideas, let me know, I'll reply ASAP !

Thanks in adance for your help,

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the Windows 7 steps with DragonFly Reverb in LMMS 1.2.0-RC7 and compare the idle CPU usage with LMMS 1.1.3. Review the bisected commit a2cb7e9 and its preceding revision for the regression. Done means the corresponding remoteVstPlugin.exe remains idle when no note is playing while saved VST projects still load correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.