LMMS / LMMS/lmms

Possible ID collision when saving a project

Open
#4,736 5 comments 0 reactions 1 assignee Claimed by @irrenhaus3 View on GitHub
bug core
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

https://github.com/LMMS/lmms/pull/2875#issuecomment-448790522:
> there might still be the potential here for ID collisions. Say a control with ID `EO_ID_MSB | 0xf00` is automated, then it will be saved with ID `0xf00`. Now, when the project is reloaded, it is possible for another control to be given ID `EO_ID_MSB | 0xf00`, which is now free, and if that were automated, an ID collision would occur when saving the file. The chances of this depend on the number of controls already automated, but `EO_ID_MSB` is 2^23 so they will tend to lie around 1 in a million.

@DomClark, do you want to handle this?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.