LMMS / LMMS/lmms

Improvement: Pitch Correction with piano roll

Open
#4,661 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

It would be useful to have the possibility to change the tone of a sample track using midi notes within the piano roll. in this way it would not be necessary to use plugins type '' autotune '', it would be better than a simple plugin of change of tone, and the change of tone would be partial and manual using the notes of the piano roll, it would be something similar to this:

![edicion de muestra con piano roll](https://user-images.githubusercontent.com/26127693/46901064-9a9b4880-ce7a-11e8-81e2-9e12a6d58bea.png)
In the image you see the piano roll interface, the notes and the sound wave of the selected sample track clip.(This idea is complemented by the suggestion of phantom notes #4575 and phantom automation #4628) but in this case it would be '' phantom sound wave '' in the background piano roll.

For this to be possible it is necessary to implement:

**In the Song Editor**
- Add the option of '' Change tone with piano roll '' in the menu of the sample track clip.
- Clicking on the option opens the piano roll automatically.

**Inside the Piano Roll**
- Show the sound wave of the sample track in ghost mode.
- Possibility of increasing and decreasing the phantom sound wave using the zoon.
- Tuner tool, detects, records the fundamental notes of the sound wave.
- Modify the waveform of the sample track according to the position and duration of the midi note in the piano roll.
- Connect Midi device, play and record the notes.
- Possibility to make choirs, chords, polyphony, and create harmonies of the sample track sound wave using the midi notes placed.
- Have the option of tone and formants separately.
- Midi note cutting tool.

Before judging me, first of all I am a '' beginner '', and secondly I have seen this function in other daw and plugin (privative by the way), I do not know if it seems a good idea, but have that possibility in the sample track would be quite useful in lmms and linux, since this function is only in proprietary software such as: antares, melodyne, newtone, etc. so far I have not seen freeware to do this, just a few simple plugins of '' autotune '' and although this idea is perhaps not completely advanced for the pitch correction standards, let's be honest, it would be very useful in lmms. and if I'm wrong or it's a duplicate you can close this thread. regards

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The requested entry points are the Song Editor and Piano Roll, but no files or tests are named. Start by locating those areas and reviewing how sample-track clips and MIDI notes are handled. The issue describes a broad pitch-correction design; completion would require an agreed, testable scope for the listed editor, waveform, tuning, and MIDI behaviors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.