Undo not working properly in Song editor
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
Several song editor actions cannot be undone (Checklist courtesy of @allejok96)
- [x] Undo insert bar #6347
- [x] Undo track color change #6165
- [ ] Undo copy paste of multiple clips #6410
Original bug report
Using Windows 10
LMMS 1.2.0 RC6
I opened a song project, and took the playhead to the start of the song and then pressed Shift+Insert key to add 5 empty bars; then I tried to undo it, but there is no response at all! LMMS is unable to undo this.
(Also note that, I went through the above mentioned steps directly after opening the project, so there is nothing else to be undone. And also, I have tried this with a completely different project, but Undo is not working.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Song editor by reproducing the remaining unchecked case: copy and paste multiple clips, then try Undo. Compare this with the already checked undo cases for inserting bars and changing track color. Done means the copied multiple clips can be undone reliably.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100