Improve logic for controllers in automation-locked state
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
This is a request rewrite of the bug #3877
The Issue:
An automation will lock controllers so *manual* changes are impossible
This is because of #3382
The controller 'remember' last downstream automation setting, and is locked in that value.
A feature is needed to force that controller to 'forget' any lock-value, and be able to stay in any *manual* made position.
The logical feature would be
**controller context-menu item *reset***
This would have to be done by user, and would be irrevisable.
Perhaps the ideal feature would be, that value-change should only occur when the cursor is manually moved and not happen mid-play unless it hits an Automation pattern.
Personally i would accept *Reset* as a solution.
A file with the locked-controller behaviour, is available in this comment: https://github.com/LMMS/lmms/issues/3877#issuecomment-347018215
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the locked-controller behavior file linked in the comment on #3877, then read the related context from #3877 and #3382. Determine how the controller retains the downstream automation value and where a user-invoked reset could be added; done means a reset restores manual control without changing the requested automation behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100