Recovery feature broken when double-clicking a project file
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 1.3k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 7
Description
This is likely a MacOS issue and I've tagged it as such. Please remove the tag if this can be reproduced on Windows or Linux.
Steps to reproduce:
1. Create and save a project
2. Experience a crash
3. Relaunch from the project file (not from the LMMS launcher icon)
Expected behavior:
1. LMMS offers to recover file, click "Recover", recover file opens!
Actual behavior:
1. LMMS offers to recover file, click "Recover", saved project file opens!
I believe this is a race condition with the way [`QApplication` handles the `fileOpen` event specific to MacOS](https://github.com/LMMS/lmms/commit/3dfd9794dbdf9284e2c8a6378139711c1cf7ef06#diff-01990f45b9969995efd402052be03d4bR841).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to QApplication fileOpen handling in the code referenced by commit 3dfd9794dbdf9284e2c8a6378139711c1cf7ef06 at diff line 841; begin there and trace how a project-file launch reaches recovery. Reproduce the macOS steps and confirm that clicking Recover opens the recovered project rather than the saved project file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, macos
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100