LMMS / LMMS/lmms

High Quality Pitch Scaler + Hard Limiter results in artefact

Open
#4,090 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug upstream
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

D.Ipsum reports this on forum:

> 1) open LMMS
> 2) add a Hard Limiter on the master
> 3) add 2 Vibed in the Song Editor
> 4) put some notes in the Piano-Roll so that both Vibed play at the same time
> 5) add a High Quality Pitch Scaler in the FX tab of both Vibed
>
> > When two instances of High Quality Pitch Scaler play at the same time, it generates a horrible noise (it's the same with TripleOsc ... I did not try on other synths)
>
> 6) Disable one of the two High Quality Pitch Scaler
>
> > When both Vibed play at the same time (so with only one High Quality Pitch Scaler), everything is fine.

Here with 3oc:
[issue_HardLimiterPitchScaler.txt](https://github.com/LMMS/lmms/files/1595887/issue_HardLimiterPitchScaler.txt)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproduction steps in the issue and inspect issue_HardLimiterPitchScaler.txt. Reproduce the artifact with two High Quality Pitch Scaler instances and the Hard Limiter, then compare it with one instance and the TripleOsc case. Done means the reported horrible noise no longer occurs in these combinations.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.