LMMS / LMMS/lmms

Midi events are modified by the MidiClients

Open
#4,076 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Most of the Midi clients modify the events in some way. For example:
- shifting one octave down
- computing pitchbend in different ways

The Midi events should never be altered.

1) Fix the funky design of MidiEvent
2) remove any shifting
3) uniformize pitchbending, panning, volume, etc
4) prefix setter/getter for LMMS with lmms
5) unprefix setter/getter for MIDI

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the MidiEvent and MidiClient implementations first, then trace how clients shift events and compute pitchbend, panning, and volume. The work is done when the five listed design and naming goals are addressed consistently across the MIDI clients, with no event modification remaining.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.