LMMS / LMMS/lmms

Peak Controller connections lost on CTRL+Z

Open
#3,944 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

LMMS Version: 1.2 RC4, Win64
OS: Win10

Issue:
Deleting a clip in the song editor belonging to an instrument with a peak controller in its FX chain will unbind the peak controller connections upon undoing the deletion (ctrl+z). It also removes any custom controller names and puts the peak controller in the bottom of the controller rack, like it is a new instance, however its settings are not lost.

Steps to Reproduce:

  1. Put a Peak Controller in the FX tab of an instrument
    1. Opt: Rename peak controller in controller rack
    2. Opt: Add additional controllers to rack
  2. Connect the controller to something
  3. Create a note clip in the song editor, verify that peak controller automates connections
  4. Delete the note clip made in the previous step
  5. Use the undo menu option or hit CRTL+Z

The Peak Controller will now have no active connections, will have lost any names given to it, and appears at the bottom of the controller rack. Its settings are not erased.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with a Peak Controller, a connected control, an optional custom name, and a deleted song-editor note clip, then undo the deletion. Trace the undo handling for clip deletion and the Peak Controller/controller rack state; done means connections, custom names, rack position, and settings remain intact after undo.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
audio-video-rtc, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.