LMMS / LMMS/lmms

Improve native compressor effect

Open
#3,817 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Original suggestion

LMMS currently have various native effects such as EQ, Reverb, Delay, and so on. However, There are no native compressors/limiters in LMMS.
And sidechaining is not easy, since it requires peak controllers(and external sidechain compressors for better quality of output), so it can't be done with just one effect in effect chain. If a native plugin supports it, it would be much easier than now.
Implementing a compressor isn't too hard, but sidechaining will require some major changes in our codebase. It requires audio signals from FX channels and/or individual tracks, which is a functionality not in LMMS yet.
So any ideas about this?

**Update 2022-02-20**: We now have a native compressor(#5458), but it can be improved in some ways:
- [ ] Sidechain support
- [x] Multiband feature(Original suggestion: #2993) (Implemented in #6925)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the native compressor introduced in #5458 and the multiband implementation in #6925, then trace how effects receive audio from FX channels and individual tracks. Done means adding sidechain support to the native compressor without losing its existing functionality.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
audio-video-rtc
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.