LMMS / LMMS/lmms

Clicking to the right of black keys plays their notes on the keyboard of the Piano Roll editor.

Open
#3,751 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug gui
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Clicking to the right of black keys plays them in the piano of the Piano Roll editor, which shouldn't happen and isn't sensible or logical.
An example of the area where this behavior is happening but it shouldn't (highlighted in yellow):
![snip_20170805194251](https://user-images.githubusercontent.com/25503477/28997175-db1e74d6-7a16-11e7-8a6d-7675f9ad6740.png)
The piano of instrument plug-ins behaves the way it should, and the piano of the Piano Roll editor should do the same.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior in the Piano Roll editor and compare it with the piano in an instrument plug-in, which the issue identifies as behaving correctly. The fix is complete when clicking to the right of a black key no longer plays that key's note.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.