LMMS / LMMS/lmms

MIDI - fixedInputVelocity applied to every event

Open
#3,694 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

MidiPort.cpp lines 131-148
The following code should be moved inside the test just above. FixedInputVelocity should only be applied to relevant events.
```
if( fixedInputVelocity() >= 0 && inEvent.velocity() > 0 )
{ inEvent.setVelocity( fixedInputVelocity() ); }
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by inspecting MidiPort.cpp lines 131-148 and the test immediately above the shown code. Move the fixedInputVelocity condition into that test, then verify that fixed input velocity is applied only to relevant events and not every MIDI event.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
audio-video-rtc
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.