LMMS / LMMS/lmms

ADSR Envelopes For Soundfont and GigaSampler Players

Open
#3,233 6 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Hello Everyone,

First off, very cool to see a GigaSampler added, I have some Giga Instruments but never really was able to use them due to the lack of VSTs that can open them, so a very nice addition, Thank You.

Anyways, it might be nice to add the ability to use an ADSR Envelope in both the Soundfont Player and the GigaSampler Player if it is possible to do so, and if others agree.

Probably not worth putting them in the "ENV/LFO" tab, but maybe adding those knobs right on main GUI itself.
The GigaSampler Player has the perfect space left open for them right below the Gain, Bank and Patch.
I obviously am not speaking for everybody, but I wouldn't mind seeing the "reverb" and the "chorus" being removed from the Soundfont Player and having them replaced by ADSR knobs.

Just an idea, if anyone else agrees or disagrees please let me know.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Soundfont Player and GigaSampler Player implementations and reviewing how their existing Gain, Bank, Patch, reverb, and chorus controls are wired. Determine the supported ADSR behavior and suitable UI placement, then define completion as both players applying and exposing the envelope consistently with coverage for the affected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
audio-video-rtc
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.