LMMS / LMMS/lmms

Piano-roll CSS grid-options for beat and tick

Open
#2,832 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement gui
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

One thing about the grid, i always felt: The _difference_ between Beat & Tick **dividers**, (the lines) are imo not 'clear', and distinctness of these lines are even more difficult in higher magnification, where the lines really are not changing in width:
![lmmsscaling](https://cloud.githubusercontent.com/assets/6662066/15891626/cf666e58-2d75-11e6-95db-2fdb5b8a0f62.png)
Here scaling to 200 % is shown in gimp to tr. and lmms 200% to tl.
Ofcause lmms will only scale horizontally, they keyboard is the reason for that, but the divider-lines are not scaled, and tick and beat dividers are very similar, as you can see in the screenie.

I have used CSS and it work better with this alpha-220 setup
![cssenhgrid](https://cloud.githubusercontent.com/assets/6662066/15929487/9257265a-2e4d-11e6-9040-d82689a356a0.png)

But the Beat & Tick-dividers are still very similar

If CSS could give an option like:
![cssdevidergrid](https://cloud.githubusercontent.com/assets/6662066/15929908/20631aec-2e50-11e6-9a13-2fb781b9168e.PNG)
It would be a huge help.
The mockup is ofcause ugly.

What are everyones thoughts on divider-line differences?

Another thing that will enhance the workflow in piano-roll, is alternate shading of bars, as known in song-editor #2308

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the piano-roll grid implementation and reviewing the referenced screenshots and the related song-editor issue #2308. Clarify the intended visual distinction between beat and tick dividers and the scope of alternate bar shading before defining what a finished change should demonstrate.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, css
Domain
design, desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.