LMMS / LMMS/lmms

use of new without delete: clean up all (most) plugin class constructors and destructors.

Open
#2,475 10 comments 0 reactions 0 assignees View on GitHub
bug core
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

looking at some of the code for instruments, there is often (SID for example) the use of _new_ without _delete_. This is a memory hole, maybe not a serious one, but none the less (C++ does not collect pointer referenced objects, it is not Java). I also noted that sometimes when _delete_ is called, it is called before rather than safely after detaching, from use by enclosing objects.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by auditing the instrument and plugin class constructors and destructors, including the SID example, for objects created with new but not released with delete. Check that deletion happens only after detaching from enclosing objects. Done means the affected classes have safe ownership and cleanup behavior, though the issue does not name specific files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.