LMMS / LMMS/lmms

Pattern Editor gives no indication when it's not possible to remove additional steps

Open
#2,326 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

In the Pattern Editor, there are buttons to remove/add/duplicate steps. When clicked, the latter two always do as their name/icon suggests. However if all patterns are only 1 bar in length, then the "remove steps" button will do nothing.

It seems appropriate that in such conditions, it should be deactivated (no mouse-over action, maybe rendered semi-transparent, etc). This kind of thing is already done with the edit -> undo/redo context options.

This also needs to be done to the "remove steps" context menu option when right-clicking on a pattern (see below).

lmms-removestepscontextoption


On a related note, the "paste" option should also be greyed out if there's no valid clipboard data. I think "clear all notes" can remain always-enabled, as it will always do as it says (performing the action on an empty pattern does indeed leave you with all notes cleared, whereas performing the "remove steps" action on a pattern of 1 bar in length does not remove any steps).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Pattern Editor controls and context menu, comparing their behavior with the existing Edit > undo/redo context options. The remove-steps actions should be visibly unavailable when patterns are only one bar long, and paste should be unavailable without valid clipboard data; clear all notes should remain enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.