LMMS / LMMS/lmms

Move notes inside a selection in piano-roll

Open
#1,930 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

This would be a very useful method, when you are working with chords:
Quite often i have chords-**selections** of 5 or more notes.
![selectedchords](https://cloud.githubusercontent.com/assets/6662066/8520976/b8985916-23df-11e5-95c7-4133bc5318a0.PNG)

These are slightly different from bar to bar - eg, a few notes is changed.

If i then want to alter _one_ of the notes in this selected chord,
![highligtednoteine](https://cloud.githubusercontent.com/assets/6662066/8520982/cc5aeb94-23df-11e5-8e8a-fd55176131ff.PNG)
i have to 'un-select' the whole selection, either
- by LMC, that will create a new note in the pos i like, and then delete the surplus note.
At the same time, the selection is de-selected. Eg -If i still want to work with this selection, I now have to re-select
![addedone](https://cloud.githubusercontent.com/assets/6662066/8521041/50a2ebb8-23e0-11e5-927f-e0f30ab9b2d6.PNG)

or
- RMC the note i like to change. That will delete _that_ note, and i can then place a new note in the new pos. At the same time, the selection is de-selected, and re-select is again necessary:
![newpnosel](https://cloud.githubusercontent.com/assets/6662066/8521121/0190643c-23e1-11e5-8b07-e38449219938.PNG)

There are several drawbacks in both these workflows:
Even though the 'job' is done,either way, it involves at least one unnecessary deletion of a note, _and_ an unwanted de-selection of the selected notes, with a re-selection as result.

What would be optimal, would be a key-press-combo that would exclude the mouse-klicked note, _from_ current selection, and allow me to move _that_ single note. At mouse-release, the note should again be inserted in the original selection.
![best](https://cloud.githubusercontent.com/assets/6662066/8521079/a87e8be4-23e0-11e5-91c0-e81f711045ba.PNG)
This whole selection is now easy to copy to the next bar

It would greatly enhance working with larger chords-selections.

((On top of this we also need #640 for working smoothly with chords))

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named. Start by reproducing the piano-roll selection and mouse-editing workflows described here, then inspect the existing selection and note-movement behavior; done means one selected note can be moved while the remaining selection is preserved and the moved note returns to the selection, while considering the related #640 work.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.