LMMS / LMMS/lmms

Piano Roll to Step Sequencer Bug

Open
#1,681 24 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug gui
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

Steps to reproduce:
1. Create four notes on the first four tombstones in a BB pattern
2. Double click the fifth tombstone to open in piano roll
3. Ctrl-drag to select the first four notes
4. Shift drag them one 1/2 note to the left (tombstones 9-12)
5. Close piano roll. Tombstones 9-12 should be lit.
6. Add a note on tombstone 6. Tombstones 9-12 should go dark.

This can be reproduced in many more situations than this one, it's just a specific example tat's easy to reproduce.

Related: https://github.com/LMMS/lmms/pull/5902#issuecomment-772740812

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named; begin by reproducing the piano-roll and step-sequencer sequence described in the issue. Trace the update from moving notes in the piano roll through closing it and adding a new step, then verify that the affected tombstones consistently light and go dark as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
audio-video-rtc, desktop-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.