LMMS / LMMS/lmms

Instrument drop-zone indicator

Open
#1,531 13 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
10.4k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
7

Description

**Edited 2014-12-31 @tresf, added comments from @DeRobyJ's bug report, mockup of drag-zones**

> If you replace the instrument of one track by drag-n-dropping a plugin/preset onto that track, you've lost the old instument.
> Of course undo-redo will make this less harmful, but it would be great to have a pop-up saying like:
> "Are you sure you want to replace this instrument?
> The current one will be lost!"
>
> **Actions:**
> - Yes - Do it like normal
> - No - Add a track with the dropped instrument
> - (Cancel - Do nothing)
>
> [extra: if the old istrument of the track is the default preset, don't show the pop-up and do the "yes" action]

![image](https://cloud.githubusercontent.com/assets/6345473/5581095/494ba0fa-9022-11e4-9121-38bec873e394.png)

![image](https://cloud.githubusercontent.com/assets/6345473/5581061/d28f9714-9021-11e4-8aca-8007dba34d39.png)

---

The way an empty instrument from sidebar, can be added to a project, can be problematic.
Reproduce:
Take any project
duplicate a track until SE is completely full
take any instrument from the sidebar ad add it.

Intuitively, a user will 'add' this new empty instrument to the project _inside_ SE, but if that is done, the new instrument overwrites the existing preset that is closest to the mouse.
Old users know, that the trick is to add the instrument _outside_ SE -eg on the scroll-bar, but that is definitively not intuitive.
I sugest some kind of 'safety' pop-up:
_"Should this empty instrument *_overwrite*\* this **existing preset?** y/n"*
If the user says n, the new instrument is then added as last instrument in the project
what do you think-

---

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the sidebar drag-and-drop behavior described in the issue, including dropping onto a full project and replacing an existing instrument. Review the attached mockups and the requested Yes, No, and Cancel outcomes. Done means accidental replacement is clearly confirmed or avoided, while declining adds the instrument as a new track.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.