Flattener does not handle DerivedParameter or ConditionalDerivedVariable
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 11
- Forks
- 11
- Avg merge
- 8h 6m
- Merged PRs (30d)
- 1
Description
Both elements are missing from https://github.com/LEMS/jLEMS/blob/master/src/main/java/org/lemsml/jlems/core/flatten/ComponentFlattener.java, and lead to errors when some NeuroML2 comp types are flattened.
@robertcannon, can you have a look at this? This can be a test case for making changes to jLEMS (in a branch of yours on jLEMS) and potentially merging them back to jLEMSDev. The versions should end up being pretty much the same (apart from ReceivePort/EventPort). Note Constant was also missing from ComponentFlattener and I've added that in jLEMS.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/main/java/org/lemsml/jlems/core/flatten/ComponentFlattener.java and compare how existing component elements, including Constant, are handled. Trace a NeuroML2 component type that uses DerivedParameter or ConditionalDerivedVariable and reproduce the flattening error. Done means both elements are handled without errors and the jLEMS and jLEMSDev versions remain aligned apart from ReceivePort/EventPort.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100