LEMS / LEMS/jLEMS

Check if overridden/extended component type in new Component actually exists

Open
#30 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
11
Forks
11
Avg merge
8h 6m
Merged PRs (30d)
1

Description

For example some Lems files ran fine with:
<abstractCell id="hhcell" type="pointCellCondBased" ...> even though abstractCell didn't exist (was renamed baseCell)
e.g. https://github.com/NeuroML/NeuroML2/blob/0c468a12d52e06b8c779bcb2d53ee280d02a768f/NeuroML2CoreTypes/LEMS_NML2_Ex1_HH.xml#L53

Would be good to catch such errors for completeness

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the LEMS_NML2_Ex1_HH.xml example at line 53 and reproduce the use of abstractCell in a new Component. Trace how overridden or extended component types are resolved, then ensure a missing type such as the renamed baseCell is rejected with a clear error. Done means invalid component types no longer run silently.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.