KusionStack / KusionStack/kuperator

Enhancement: there need to be some comment to explain PodOpsLifecycle procedure

Open
#27 0 comments 0 reactions 1 assignee View on GitHub

@shaofan-hs is already working on this.

Since Aug 16, 2023.

kind/enhancement operating
Dominant language
Go
Stars
100
Forks
12
PR merge metrics
No merged PRs in 30d

Description

What would you like to be added?

add some comment to explain PodOpsLifecycle procedure in webhook codes, like here https://github.com/KusionStack/kafed/blob/main/pkg/webhook/server/generic/pod/opslifecycle/webhook.go#L123

also the codes here could be refactored more readable.

Why is this needed?

Users may be confused while reading these codes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.