Kureev / Kureev/react-native-navbar
Disabled option in button configs doesn't work
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.9k
- Forks
- 318
- PR merge metrics
- No merged PRs in 30d
Description
Hi, after trying to use the disabled option and seeing that it wasn't doing anything, I tried to figure out what was wrong and I think that functionality stopped working almost immediately after it was released. I took a look at the code for release 1.6.0 and getButtonElement passes in disabled={data.disabled} to the NavbarButton, but the 1.6.1 release afterwards no longer contains that line. I checked release 2.1 to see if it was added back at some point but it doesn't seem like it was.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating getButtonElement and NavbarButton, then compare their implementations between releases 1.6.0 and 1.6.1. Confirm the disabled option is forwarded as described and verify that button configurations with disabled set no longer leave the button active.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100