Kureev / Kureev/browserify-react-live

Live update fails when requiring npm dependencies

Open
#15 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
80
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Hey, just want to say this project looks sweet from the demos and I really hope I can get it working for me. I ran into an issue when trying this library on my own codebase and was able to reproduce in the example 01 demo app too.

At the top of [MyComponent.js](https://github.com/Kureev/browserify-react-live/blob/778041de556447005c334775c86f1a5f42ce3df8/examples/01%20-%20Basic/components/MyComponent.js) I added the line `var $ = require('jquery');` and then npm installed jquery and ran the app with `npm start`. It starts up fine, watchify is able to find jquery and bundle the app. But now when I make a change in that same file, the patch fails with an error (attached screenshot of chrome dev console).

screen shot 2015-12-06 at 9 36 52 pm

Any idea how to fix this?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with examples/01 - Basic/components/MyComponent.js and reproduce the failure by requiring jquery, installing it, running npm start, then editing the same file. Inspect the Chrome console error and the live-update path; done means edits to a file with an npm dependency apply successfully without the patch failing.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery, react
Domain
frontend, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.