Kunzisoft / Kunzisoft/KeePassDX
AutofillValue logged in debug output
- Dominant language
- Kotlin
- Stars
- 7.3k
- Forks
- 401
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 1
Description
### Checks
- [x] I have read the Wiki, searched the open issues, and still think this is a new bug.
### Explain the problem clearly and succinctly:
**File:** `app/src/main/java/com/kunzisoft/keepass/credentialprovider/autofill/AutofillHelper.kt:167`
```kotlin
Log.d(TAG, "Set Autofill value $autofillValue for id $id")
```
This log statement executes for every autofill value, including password fields. While `AutofillValue.toString()` typically masks text content, some custom ROMs or debug builds may expose actual values. Recommend removing this log or only logging the value type.
## Excessive debug logging in StructureParser
File: app/src/main/java/com/kunzisoft/keepass/credentialprovider/autofill/StructureParser.kt
~40 Log.d statements leak UI structure information. Recommend using BuildConfig.DEBUG conditional or removing in release builds.
### Describe what you expected to happen:
_No response_
### KeePassDX version:
4.3.3
### Build:
Free, Libre
### Database version:
_No response_
### File provider (`content://` URI)
_No response_
### Android version:
_No response_
### Android device:
_No response_
### Additional context:
Linked to #2480
Contributor guide
Research direction
Start with app/src/main/java/com/kunzisoft/keepass/credentialprovider/autofill/AutofillHelper.kt:167 and review the Log.d statement, then inspect the Log.d statements in StructureParser.kt. Confirm that autofill values and UI structure details are not exposed in release logging while preserving any explicitly intended debug information. Done means both files no longer leak sensitive values or structure information in release builds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile-dev, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100