Kuadrant / Kuadrant/kuadrant-operator
log all missing CRDs when detecting if dependency is missing
- Dominant language
- Go
- Stars
- 94
- Forks
- 89
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 43
Description
# Description
Highlighted in https://github.com/Kuadrant/kuadrant-operator/pull/994#discussion_r1916858450, we should log all missing CRDs/errors when determining a dependency is missing or not at once instead of sequentially. We should also potentially report the error in the CR status as while missing CRD is an inference that an dependency is missing, this may not always be the case such:
- Only dependent CRD version is missing
- Error is CRD detection logic
Places to be updated include:
- https://github.com/Kuadrant/kuadrant-operator/blob/3037523990f754050a458c934e0643113ebaab3e/pkg/authorino/conditions.go#L24-L36
- https://github.com/Kuadrant/kuadrant-operator/blob/3037523990f754050a458c934e0643113ebaab3e/pkg/gatewayapi/utils.go#L123-L140
- https://github.com/Kuadrant/kuadrant-operator/blob/3037523990f754050a458c934e0643113ebaab3e/pkg/istio/utils.go#L135-L154
- https://github.com/Kuadrant/kuadrant-operator/blob/3037523990f754050a458c934e0643113ebaab3e/pkg/envoygateway/utils.go#L44-L63
- Possibly others. Looks through https://github.com/Kuadrant/kuadrant-operator/blob/main/controllers/state_of_the_world.go for functions where more than 1 CRD is checked for determining if a dependency is installed or not
Contributor guide
Research direction
Start with the dependency checks in pkg/authorino/conditions.go, pkg/gatewayapi/utils.go, pkg/istio/utils.go, and pkg/envoygateway/utils.go, then inspect controllers/state_of_the_world.go for other multi-CRD checks. Determine how all missing CRDs or detection errors can be reported together and whether the dependent CR status should expose them; done means the relevant checks no longer report failures sequentially.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100