KotlinIsland / KotlinIsland/basedmypy

`explicit-override` shouldn't apply to dunders directly from `object`

Open
#494 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
Python
Stars
202
Forks
6
PR merge metrics
No merged PRs in 30d

Description

```py
class A:
def __str__(self): ... # don't expect error

class B(A):
def __str__(self): ... # expect error
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation and tests for the `explicit-override` check, then trace how dunder methods inherited from `object` are distinguished from methods inherited through `A`. Use the two examples in the issue as regression cases; done means `B.__str__` requires the override marker while `A.__str__` does not.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.