Kotlin / Kotlin/dataframe

Trino Support

Open
#850 1 comment 1 reaction 1 assignee View on GitHub

@zaleslaw is already working on this.

Since Sep 3, 2024.

databases enhancement
Dominant language
Kotlin
Stars
1.1k
Forks
83
Avg merge
4d 12h
Merged PRs (30d)
30

Description

We're using Trino (previously called Presto) and it would be great to have first party support for Trino in dataframe.

With this little hack (delegating it to Postgre) it's already working for us but this is probably not a solution for all cases:

object Trino : DbType("trino") {

  override val driverClassName: String = "io.trino.jdbc.TrinoDriver"

  override fun buildTableMetadata(tables: ResultSet): TableMetadata = PostgreSql.buildTableMetadata(tables)

  override fun convertSqlTypeToColumnSchemaValue(tableColumnMetadata: TableColumnMetadata): ColumnSchema? =
    PostgreSql.convertSqlTypeToColumnSchemaValue(tableColumnMetadata)

  override fun convertSqlTypeToKType(tableColumnMetadata: TableColumnMetadata): KType? =
    PostgreSql.convertSqlTypeToKType(tableColumnMetadata)

  override fun isSystemTable(tableMetadata: TableMetadata): Boolean = PostgreSql.isSystemTable(tableMetadata)
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.