Kotlin / Kotlin/dataframe

Add tests for `unfold`

Open
#677 4 comments 0 reactions 0 assignees View on GitHub
tests
Dominant language
Kotlin
Stars
1.1k
Forks
83
Avg merge
4d 12h
Merged PRs (30d)
30

Description

As the title says.
Unfold is a sort-of in-dataframe `.toDataFrame()` conversion (https://kotlin.github.io/dataframe/unfold.html), but this behavior isn't tested anywhere, nor do we check it's consistent with our `Iterable<>.toDataFrame()` overloads.

Related to unfold, we should probably rename `AnyCol.isPrimitive()` and `KClass<*>.isPrimitive()` to `isValueType()` or something, because "primitive" has a different meaning in the JVM world.

Contributor guide

Open the contributing guide

Research direction

Start by locating the `unfold` implementation and the existing `Iterable<>.toDataFrame()` overloads, then read the linked unfold documentation for the intended behavior. Add tests covering unfold and consistency with those overloads; treat the possible `AnyCol.isPrimitive()` and `KClass<*>.isPrimitive()` rename as a separate scope decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
data, testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.