Kotlin / Kotlin/dataframe

Simplify compilation of :core tests with compiler plugin enabled for better E2E testing

Open
#1,841 0 comments 1 reaction 0 assignees View on GitHub
tests
Dominant language
Kotlin
Stars
1.1k
Forks
83
Avg merge
4d 12h
Merged PRs (30d)
30

Description

In tests we have all sorts of dataframe code. Compiling it with compiler plugin could help us catch bugs earlier. For example, regression causing compiler crash found by user was reproducable in one of the tests.
https://github.com/Kotlin/dataframe/issues/1723

Problem:
Simply enabling plugin, we still have a bunch of errors before we could compile:
Image

Goal: I have no intention to enable plugin by default (yet?), but it would be nice to only have to apply a small patch that enables it and simply run "test" task. So need to go over all compilation errors and fix what's possible

Most of them can be fixed by slightly changing the code of a test itself, in some cases i'll adjust compiler plugin to be not so strict/invasive.

Contributor guide

Open the contributing guide

Research direction

Start with the :core tests and the compilation errors produced when the compiler plugin is enabled; review the linked regression issue #1723 for context. Work through the test and compiler-plugin changes needed without enabling the plugin by default. Done means the test task runs successfully with the plugin enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
build-system, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.