`DataColumnArithmetics.kt` inconsistencies
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 1.1k
- Forks
- 83
- Avg merge
- 4d 12h
- Merged PRs (30d)
- 30
Description
There are three things in DataColumnArithmetics.kt that need to be changed:
- In the functions
public operator fun AnyCol.plus(str: String): DataColumn<String> = map { it.toString() + str }
// and
public operator fun ColumnReference<Any?>.plus(str: String): ColumnReference<String> = map { it.toString() + str }
if the column contains null values, these functions convert each null to the string "null" and concatenate the argument str with it. These functions should be changed in a way that the null values are preserved. That is, each null value in the original column results in a null value for the corresponding element in the resulting column.
-
The functions
gtandltare not defined for nullable types. They should also work on columns that containnullvalues. -
We need to add to this file new functions:
geq(greater than or equal to) andleq(less than or equal to).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading DataColumnArithmetics.kt and inspect the plus, gt, and lt functions, including their nullable-type handling. Update the requested arithmetic behavior and add geq and leq; done means null values remain null and all four comparison operations are available as specified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100